Skip to content

Support GroupedGemm types hhs,hss#7273

Merged
jichangjichang merged 2 commits into
ROCm:developfrom
mengzcai:users/mengzcai/logic-yaml-GG-tdm
May 14, 2026
Merged

Support GroupedGemm types hhs,hss#7273
jichangjichang merged 2 commits into
ROCm:developfrom
mengzcai:users/mengzcai/logic-yaml-GG-tdm

Conversation

@mengzcai

@mengzcai mengzcai commented May 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • enable groupedgemm hhs,hss in gtest
  • add logic yamls with tdm3

Motivation

Add GroupedGemm support for HHS and HSS data types on gfx1250 with TDM3 kernels.

Technical Details

  • Logic YAMLs: Added TDM3 kernel configurations for GroupedGemm HHS and HSS types on gfx1250
  • gtest: Enabled GroupedGemm HHS/HSS in matmul_gtest.yaml by updating gpu_arch_exclude regex from '1[1-2]\d{2}' to
    '11\d{2}|120\d{1}', allowing gfx1250 to run these tests

Test Plan

  • Verified GroupedGemm HHS/HSS kernels are generated from the new logic YAMLs
  • Ran matmul_groupedgemm and matmul_groupedgemm_f32 gtests on gfx1250

Test Result

  • no CI validation currently
  • test hipblaslt-test on local

Submission Checklist

@mengzcai
Support GroupedGemm types hhs,hss
c2b860b 
- enable groupedgemm hhs,hss in gtest
- add logic yamls with tdm3
@mengzcai mengzcai requested a review from jichangjichang May 11, 2026 10:07
@mengzcai mengzcai requested a review from a team as a code owner May 11, 2026 10:07
@codecov-commenter

codecov-commenter commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (69.24%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #7273   +/-   ##
========================================
  Coverage    64.36%   64.36%           
========================================
  Files          603      603           
  Lines       112196   112196           
  Branches     15498    15498           
========================================
  Hits         72205    72205           
  Misses       34724    34724           
  Partials      5267     5267
Flag Coverage Δ *Carryforward flag
hipBLASLt 39.85% <ø> (ø)
hipDNN 85.56% <ø> (ø) Carriedforward from 171d97b
hipFFT 49.22% <ø> (ø) Carriedforward from 171d97b
hipSOLVER 69.24% <ø> (ø) Carriedforward from 171d97b
rocFFT 47.60% <ø> (ø) Carriedforward from 171d97b
rocRAND 57.02% <ø> (ø) Carriedforward from 171d97b

*This pull request uses carry forward flags. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jichangjichang jichangjichang merged commit d5d14cf into ROCm:develop May 14, 2026
34 of 35 checks passed
assistant-librarian Bot pushed a commit to ROCm/hipBLASLt that referenced this pull request May 14, 2026
@mengzcai @assistant-librarian
[rocm-libraries] ROCm/rocm-libraries#7273 (commit d5d14cf)
2e95b6e 
Support GroupedGemm types hhs,hss

- enable groupedgemm hhs,hss in gtest
- add logic yamls with tdm3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jichangjichang jichangjichang jichangjichang approved these changes

@geotseng-amd geotseng-amd geotseng-amd approved these changes

Assignees

No one assigned

Labels

organization: ROCm project: hipblaslt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mengzcai @codecov-commenter @jichangjichang @geotseng-amd